Remove bash invocation on Windows in rebar_utils:sh/2
jan.kloetzke at freenet.de
Sat Oct 1 15:07:30 EDT 2011
On Saturday 01 October 2011, Tim Watson <watson.timothy at gmail.com> wrote:
> On 1 October 2011 08:01, Jan Klötzke <jan.kloetzke at freenet.de> wrote:
> > > This still requires unix tool chain such as msys to be installed in
> > > Windows. Relying on pure Erlang code or the built-in Windows tool chain
> > > (cmd.exe, findstr, etc) means all Windows users benefit from being able
> > to
> > > use rebar without installing things they don't necessarily need or
> > > want.
> > I know but I'd like to do it in a separate step once the bash removal on
> > Windows is deemed safe...
> Ah ok that makes perfect sense.
Ok, I've updated my pull request and simplified things a bit by always using
cmd.exe in rebar_utils:sh/2. Nearly every command used it anyways.
Looks pretty smooth now IMHO (despite the fact we are still relying on 'grep'
and 'tee' in the 'ct' target and the erlydtl and neotoma compilers)...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: This is a digitally signed message part.
More information about the rebar