Remove bash invocation on Windows in rebar_utils:sh/2
jan.kloetzke at freenet.de
Mon Oct 3 11:13:15 EDT 2011
On Monday 03 October 2011, David Smith <dizzyd at basho.com> wrote:
> Thanks for submitting this patch. Should we just define a portable
> interface for doing things like copy/move/grep and have modules
> appropriate to each? I'm starting to feel like there is a lot of
> Windows-specific cases scattered about the code base and I wonder if
> it's time to consolidate the interface a bit...
I agree. Actually the rebar_file_utils module is exactly there to encapsulate
these specifics of file management (as far as I understand). I thing adding a
portable 'grep' to this module makes perfect sense. Apart from this, the other
locations where we check the OS type are unavoidable IMHO.
I think if we could keep the OS specifics solely in rebar_file_utils and
rebar_utils then it's already in quite a good shape...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: This is a digitally signed message part.
More information about the rebar