erlang:phash2(now())

David Smith dizzyd at basho.com
Thu Oct 7 23:13:19 EDT 2010


Please file an issue in bugzilla (http://issues.basho.com) with either
a patch, or a reference to a git or mercurial repo. I can't guarantee
that we'll accept every patch, but I do promise to give it a serious
review.

Thanks. :)

D.

On Fri, Oct 8, 2010 at 2:46 AM, Lev Walkin <vlm at lionet.info> wrote:
> Do you have a robust policy of accepting outside patches?
>
> On Oct 7, 2010, at 6:47 PM, David Smith wrote:
>
>>> make_ref is 6 times faster than erlang:phash2(make_ref()) which is 50%
>>> faster than erlang:phash2(now()).
>>>
>>> Of course, in the grand scheme of things this might not be your biggest
>>> bottleneck, but why hashing now() when there exsists an idiomatic
>>> make_ref()
>>> solution? Am I missing something?
>>
>> You're not missing anything, I think. make_ref() seems like a logical
>> and reasonable alternative. As you said, however, it's not (anywhere
>> near) our biggest bottleneck -- last time I ran the profiler it didn't
>> even show up in the top 100 hotspots. :)
>>
>> Thanks,
>>
>> D.
>
> --
> vlm
>
>




More information about the riak-users mailing list